[
https://issues.apache.org/jira/browse/SOLR-17924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18079730#comment-18079730
]
Chris M. Hostetter commented on SOLR-17924:
-------------------------------------------
Christos: For reasons I don't understand, running {{gradle tidy}} on main wants
to make the following change to some of your recent additions ...
{noformat}
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
index 7018c17a31e..d2d521b5692 100644
--- a/gradle/libs.versions.toml
+++ b/gradle/libs.versions.toml
@@ -240,8 +240,8 @@ amazon-awssdk-s3 = { module = "software.amazon.awssdk:s3",
version.ref = "amazon
amazon-awssdk-sdkcore = { module = "software.amazon.awssdk:sdk-core",
version.ref = "amazon-awssdk" }
amazon-awssdk-sts = { module = "software.amazon.awssdk:sts", version.ref =
"amazon-awssdk" }
androidx-lifecycle-runtimeCompose = { module =
"org.jetbrains.androidx.lifecycle:lifecycle-runtime-compose", version.ref =
"androidx-lifecycle" }
-androidx-lifecycle-viewmodelCompose = { module =
"org.jetbrains.androidx.lifecycle:lifecycle-viewmodel-compose", version.ref =
"androidx-lifecycle" }
androidx-lifecycle-viewModelNav3 = { module =
"org.jetbrains.androidx.lifecycle:lifecycle-viewmodel-navigation3", version.ref
= "androidx-lifecycle" }
+androidx-lifecycle-viewmodelCompose = { module =
"org.jetbrains.androidx.lifecycle:lifecycle-viewmodel-compose", version.ref =
"androidx-lifecycle" }
androidx-material3-adaptive = { module =
"org.jetbrains.compose.material3.adaptive:adaptive", version.ref =
"androidx-adaptive" }
androidx-material3-adaptive-nav3 = { module =
"org.jetbrains.compose.material3.adaptive:adaptive-navigation3", version.ref =
"androidx-adaptive" }
androidx-navigation3-ui = { module =
"org.jetbrains.androidx.navigation3:navigation3-ui", version.ref =
"androidx-navigation3" }
{noformat}
....are you seeing that locally?
It took me a minute to wrap my head around why it didn't like your existing
ordering – but I _think_ the problem is you capitalized "Model" in
{{viewModelNav3}} but not in {{viewmodelCompose}} and capital "M" should sort
before lowercase "m" ?
Can those names be changed to use consistent capitalization? (or all lowercase
with/hyphens)
> Create Configset Dialog
> -----------------------
>
> Key: SOLR-17924
> URL: https://issues.apache.org/jira/browse/SOLR-17924
> Project: Solr
> Issue Type: Sub-task
> Components: Admin UI
> Reporter: Christos Malliaridis
> Assignee: Christos Malliaridis
> Priority: Major
> Labels: new-ui, newdev, pull-request-available, ui
> Fix For: main(11.0)
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In the configsets section of the new UI the user should be able to add a new
> configset.
> h2. Task
> Implement the configset dialog that allows the user to create a new configset
> and that uses existing configsets.
> h2. Acceptance Criteria
> - The user can insert a name for the new configset
> - The user can choose a base configset from the existing configsets
> - The dialog's dropdown for selecting a configset may use the currently
> selected configset from the Configsets section as default
> - The default configset (_default) is selected by default
> - When the configset is successfully created and the dialog is closed, the
> ConfigsetsComponent from the section updates its current selection options
> and selects to the new congiset
> - The dialog is closed if the configset is created successfully
> - The dialog shows the error if a configset could not be created for some
> reason
> - The configset name is validated with the existing configsets
> - existing name conflicts are shown as error in the input field
> - no request is sent in case of a conflict
> You should not implement hte configset import feature that is currently
> present in the designs, as this will be a separate task.
> h2. Additional Information
> The existing ConfigsetsComponent interface may be reused and the
> DefaultConfigsetsImplementation may be updated if used and changes are
> necessary. Avoid code duplication if the same functionality is in the
> existing components (e.g. configset selection dropdown).
> For the edge-case where no configsets are available (not even _default) a
> request should be sent without a baseConfigset set. If the missing default
> configset triggers an error it should be shown to the user. No further error
> handling has to be implemented.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
