janhoy commented on code in PR #2391:
URL: https://github.com/apache/solr/pull/2391#discussion_r3217152288
##########
solr/core/src/java/org/apache/solr/cloud/SolrZkServer.java:
##########
@@ -253,10 +263,10 @@ public static Properties getProperties(Path configPath)
throws ConfigException {
// Given zkHost=localhost:1111,localhost:2222 this will inject
// server.0=localhost:1112:1113
// server.1=localhost:2223:2224
- public static void injectServers(Properties props, boolean zkRun, String
zkHost) {
+ public static void injectServers(Properties props, String zkHost) {
// if clientPort not already set, use zkRun
- if (zkRun && props.getProperty("clientPort") == null) {
+ if (props.getProperty("clientPort") == null) {
// int portIdx = zkRun.lastIndexOf(':');
int portIdx = "".lastIndexOf(':');
Review Comment:
@epugh This line was modified by you and causes the below if() to be dead
code. Remember what's going on here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
