alessandrobenedetti commented on code in PR #4259:
URL: https://github.com/apache/solr/pull/4259#discussion_r3219694670
##########
solr/modules/language-models/src/test/org/apache/solr/languagemodels/store/rest/TestTextToVectorModelManager.java:
##########
@@ -27,7 +27,7 @@
import org.junit.BeforeClass;
import org.junit.Test;
-public class TestModelManager extends TestLanguageModelBase {
+public class TestTextToVectorModelManager extends TestLanguageModelBase {
Review Comment:
What about this?
##########
solr/modules/language-models/src/test/org/apache/solr/languagemodels/store/rest/TestTextToVectorModelManagerPersistence.java:
##########
@@ -21,7 +21,7 @@
import org.junit.Before;
import org.junit.Test;
Review Comment:
another suspicious spurious change
##########
solr/modules/language-models/src/test/org/apache/solr/languagemodels/update/processor/TextToVectorUpdateProcessorTest.java:
##########
@@ -51,7 +51,7 @@ public void afterEachTest() throws Exception {
@Test
public void processAdd_inputField_shouldVectoriseInputField() throws
Exception {
- loadModel("dummy-model.json"); // preparation
+ loadTextToVectorModel("dummy-model.json"); // preparation
Review Comment:
another spurious change
##########
solr/modules/language-models/src/test/org/apache/solr/languagemodels/search/TextToVectorQParserTest.java:
##########
@@ -28,7 +28,7 @@ public class TextToVectorQParserTest extends
TestLanguageModelBase {
@BeforeClass
public static void init() throws Exception {
setupTest("solrconfig-language-models.xml", "schema-language-models.xml",
true, false);
- loadModel("dummy-model.json");
+ loadTextToVectorModel("dummy-model.json");
Review Comment:
What about this?
##########
solr/modules/language-models/src/test/org/apache/solr/languagemodels/TestLanguageModelBase.java:
##########
@@ -87,7 +104,7 @@ protected static void afterTest() throws Exception {
}
}
- public static void loadModel(String fileName, String status) throws
Exception {
+ public static void loadTextToVectorModel(String fileName, String status)
throws Exception {
Review Comment:
spurious change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
