janhoy commented on PR #4284:
URL: https://github.com/apache/solr/pull/4284#issuecomment-4435659777
> CC @sigram. We should add `solr.` prefix. Tbh I don't know enough about
the crossdc module but to me seems like we don't need `core` there.
### Proposal: Rename CrossDC metric names
Following @mlbiscoc's suggestion — add `solr.` prefix to consumer metrics
and remove the spurious `.core.` segment from producer metrics. This makes both
sides symmetric under `solr.crossdc.*`.
#### Consumer: `crossdc.consumer.` → `solr.crossdc.consumer.`
| Old | New |
|---|---|
| `crossdc.consumer.input.msg.total` |
`solr.crossdc.consumer.input.msg.total` |
| `crossdc.consumer.input.req.total` |
`solr.crossdc.consumer.input.req.total` |
| `crossdc.consumer.collapsed.total` |
`solr.crossdc.consumer.collapsed.total` |
| `crossdc.consumer.output.total` | `solr.crossdc.consumer.output.total` |
| `crossdc.consumer.output.batch_size` |
`solr.crossdc.consumer.output.batch_size` |
| `crossdc.consumer.output.backoff_time` |
`solr.crossdc.consumer.output.backoff_time` |
| `crossdc.consumer.output.time` | `solr.crossdc.consumer.output.time` |
| `crossdc.consumer.output.first_attempt_time` |
`solr.crossdc.consumer.output.first_attempt_time` |
Prometheus gains a `solr_` prefix: `crossdc_consumer_output_total` →
`solr_crossdc_consumer_output_total`
#### Producer: `solr.core.crossdc.producer.` → `solr.crossdc.producer.`
| Old | New |
|---|---|
| `solr.core.crossdc.producer.local.processed` |
`solr.crossdc.producer.local.processed` |
| `solr.core.crossdc.producer.submitted` |
`solr.crossdc.producer.submitted` |
| `solr.core.crossdc.producer.submitted.add` |
`solr.crossdc.producer.submitted.add` |
| `solr.core.crossdc.producer.submitted.delete_by_id` |
`solr.crossdc.producer.submitted.delete_by_id` |
| `solr.core.crossdc.producer.submitted.delete_by_query` |
`solr.crossdc.producer.submitted.delete_by_query` |
| `solr.core.crossdc.producer.submitted.commit` |
`solr.crossdc.producer.submitted.commit` |
| `solr.core.crossdc.producer.document_size` |
`solr.crossdc.producer.document_size` |
| `solr.core.crossdc.producer.doc_too_large_errors` |
`solr.crossdc.producer.doc_too_large_errors` |
Prometheus: `solr_core_crossdc_producer_*` → `solr_crossdc_producer_*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
