janhoy commented on code in PR #4271: URL: https://github.com/apache/solr/pull/4271#discussion_r3248370648
########## dev-docs/ref-guide/antora.adoc: ########## @@ -61,6 +61,38 @@ Instead, update `antora.template.yaml`, and `gradlew buildLocalSite` will build The only reason you will likely need to change the `antora.template.yml` is if you are introducing new variables for dependency versions. +== Auto-generated CLI Reference Pages Review Comment: Checking them in gives less "magic" and will also help surface unintended CLI contract edites in tools as the PR will fail precommit, needing to re-generate docs. Then one can review if the change was intended and back-compat before calling generateCliDocs... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
