Copilot commented on code in PR #4:
URL: https://github.com/apache/solr-orbit/pull/4#discussion_r3288829416
##########
tests/utils/process_test.py:
##########
@@ -125,16 +125,16 @@ def test_kills_only_benchmark_processes(self,
process_iter):
"org.elasticsearch.bootstrap.Elasticsearch"])
random_python = ProcessTests.Process(103, "python3",
["/some/django/app"])
other_process = ProcessTests.Process(104, "init", ["/usr/sbin/init"])
- benchmark_process_p = ProcessTests.Process(105, "python3",
["/usr/bin/python3", "~/.local/bin/solr-benchmark"])
- # On Linux, process names up to 15 chars are not truncated;
solr-benchmark is exactly 15 chars.
- benchmark_process_l = ProcessTests.Process(106, "solr-benchmark",
["/usr/bin/python3", "~/.local/bin/solr-benchmark"])
- benchmark_process_e = ProcessTests.Process(107, "solr-benchmark",
["/usr/bin/python3", "~/.local/bin/solr-benchmark"])
+ benchmark_process_p = ProcessTests.Process(105, "python3",
["/usr/bin/python3", "~/.local/bin/solr-orbit"])
+ # On Linux, process names up to 15 chars are not truncated; solr-orbit
is exactly 15 chars.
+ benchmark_process_l = ProcessTests.Process(106, "solr-orbit",
["/usr/bin/python3", "~/.local/bin/solr-orbit"])
Review Comment:
The comment says "solr-orbit is exactly 15 chars", but "solr-orbit" is 9
characters. Please update/remove this comment so it accurately reflects the
Linux 15-character process name behavior (or adjust the explanation to what is
being tested here).
##########
AGENTS.md:
##########
@@ -36,12 +36,12 @@ make clean # Remove build artifacts, caches, tox
environments
## Architecture
-Apache Solr Benchmark (ASB) is a **macrobenchmarking framework** for Apache
Solr clusters, using an **actor-based concurrent execution model** via the
[Thespian](https://thespianpy.com/) library.
+Apache Solr Orbit (ASB) is a **macrobenchmarking framework** for Apache Solr
clusters, using an **actor-based concurrent execution model** via the
[Thespian](https://thespianpy.com/) library.
Review Comment:
This line introduces the acronym "ASB" for "Apache Solr Orbit", but ASB
historically expands to "Apache Solr Benchmark". Please update the acronym (or
drop it) to avoid confusing readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
