Copilot commented on code in PR #18: URL: https://github.com/apache/solr-orbit/pull/18#discussion_r3293573337
########## DEVELOPER_GUIDE.md: ########## @@ -15,7 +15,7 @@ Apache Solr Benchmark. ## Prerequisites -- **Python 3.9+**: Use [pyenv](https://github.com/pyenv/pyenv) to manage +- **Python 3.12+**: Use [pyenv](https://github.com/pyenv/pyenv) to manage Python versions. Review Comment: This doc updates the minimum Python version to 3.12+, but other user-facing docs still state 3.10 (e.g., `docs/quickstart.md` and `docs/user-guide/install-and-configure/installing.md`). Please update those docs (and any other references like AGENTS.md) to keep installation guidance consistent with the new requirement. ########## setup.py: ########## @@ -47,7 +47,7 @@ def str_from_file(name): long_description = str_from_file("README.md") # tuples of (major, minor) of supported Python versions ordered from lowest to highest -supported_python_versions = [(3, 10), (3, 11), (3, 13)] +supported_python_versions = [(3, 12), (3, 13)] Review Comment: Raising the minimum supported Python to 3.12 will cause `pip install -e .` to fail when `make develop` (and CI via `.ci/build.sh`) still installs/targets Python 3.10 (`Makefile:pyinst310` / `.ci/variables.json:MIN_PY_VER`). Please update the build tooling (e.g., `.ci/variables.json` MIN_PY_VER and the Makefile `pyinst<min>`/`develop` targets) to use 3.12+ so development setup and CI remain functional. ########## tox.ini: ########## @@ -7,7 +7,7 @@ ############################################################################### [tox] envlist = - py310,py311,py312,py313 + py312,py313 platform = Review Comment: `tox.ini` no longer defines `py310`/`py311`, but the repository still has `make it310`/`make it311` targets that invoke `tox -e py310/py311` (Makefile lines ~91-94). Those targets (and any CI scripts calling them) will start failing after this change. Please remove/adjust the Makefile targets and any related CI matrices to match the new `envlist`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
