Copilot commented on code in PR #42:
URL: https://github.com/apache/solr-orbit/pull/42#discussion_r3320524173
##########
benchmark:
##########
@@ -39,7 +39,7 @@ cd "${BENCHMARK_SRC_HOME}" >/dev/null 2>&1
# set variables that are needed for run.sh
-__BENCHMARK_INTERNAL_BINARY_NAME="osbenchmark"
+__BENCHMARK_INTERNAL_BINARY_NAME="solrorbit"
Review Comment:
`__BENCHMARK_INTERNAL_BINARY_NAME` is set to `solrorbit`, but the packaged
console script in `pyproject.toml` is named `solr-orbit`. As a result, `run.sh`
will try to execute `${USER_BASE}/bin/solrorbit`, which likely won't exist
after `pip install` (only `solr-orbit` will). Update this to `solr-orbit` (or
add matching console scripts for `solrorbit`).
##########
CREATE_WORKLOAD_GUIDE.md:
##########
@@ -51,7 +51,7 @@ If you have a workload written for OpenSearch Benchmark, use
the migration
utility to translate it to Solr format:
```bash
-python -m osbenchmark.tools.migrate_workload \
+python -m solrorbit.tools.migrate_workload \
Review Comment:
The guide references `python -m solrorbit.tools.migrate_workload`, but
`solrorbit/tools/` currently contains only `__init__.py` (no `migrate_workload`
module). This command will fail for users. Update the docs to point at the
supported conversion entry point (e.g., the `solr-orbit convert-workload`
subcommand or `solrorbit.conversion.workload_converter`).
##########
benchmarkd:
##########
@@ -41,7 +41,7 @@ cd "${BENCHMARK_SRC_HOME}" >/dev/null 2>&1
export PYTHONPATH="${BENCHMARK_SRC_HOME}:${PYTHONPATH:-}"
# set variables that are needed for run.sh
-__BENCHMARK_INTERNAL_BINARY_NAME="osbenchmarkd"
+__BENCHMARK_INTERNAL_BINARY_NAME="solrorbitd"
Review Comment:
`__BENCHMARK_INTERNAL_BINARY_NAME` is set to `solrorbitd`, but
`pyproject.toml` defines the console script as `solr-orbitd`. This will make
`run.sh` look for `${USER_BASE}/bin/solrorbitd` after installation, which
likely doesn't exist. Align the internal binary name with the configured script
name (or add a matching entry point).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
