jaykay12 commented on code in PR #4452:
URL: https://github.com/apache/solr/pull/4452#discussion_r3321863693
##########
solr/core/src/java/org/apache/solr/handler/component/ActiveTasksListHandler.java:
##########
@@ -23,37 +23,42 @@
import org.apache.solr.api.Api;
import org.apache.solr.api.JerseyResource;
import org.apache.solr.client.api.model.ActiveTaskDetails;
+import org.apache.solr.client.api.model.TaskStatusResponse;
import org.apache.solr.common.util.NamedList;
+import org.apache.solr.handler.admin.api.GetTaskStatus;
import org.apache.solr.handler.admin.api.ListActiveTasks;
-import org.apache.solr.handler.api.V2ApiUtils;
import org.apache.solr.request.SolrQueryRequest;
import org.apache.solr.request.SolrRequestHandler;
import org.apache.solr.response.SolrQueryResponse;
import org.apache.solr.security.AuthorizationContext;
import org.apache.solr.security.PermissionNameProvider;
/**
- * Handles request for listing all active cancellable tasks All active tasks
logic lives in the v2
- * {@link ListActiveTasks}; this handler is a thin v1 bridge that extracts
request parameters and
- * delegates.
+ * Handles request for listing the active cancellable tasks and Status check
of any particular task,
Review Comment:
> are there active tasks that are NOT cancellable?
there can be. since this is the kind of function that we invoke, having
cancellable in the javadoc looks fine to me.
`getCore().getCancellableQueryTracker().getActiveQueriesGenerated()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
