janhoy commented on code in PR #4473:
URL: https://github.com/apache/solr/pull/4473#discussion_r3324283206
##########
solr/bin/solr:
##########
@@ -371,11 +371,14 @@ function print_usage() {
if [[ "$CMD" == "start" || "$CMD" == "restart" ]]; then
echo ""
- echo "Usage: solr $CMD [-f] [--user-managed] [--host host] [-p port]
[--server-dir directory] [-z zkHost] [-m memory] [-e example] [--solr-home
solr.solr.home] [--data-home solr.data.home] [--jvm-opts \"jvm-opts\"]
[--verbose]"
+ echo "Usage: solr $CMD [-f] [-c] [--user-managed] [--host host] [-p port]
[--server-dir directory] [-z zkHost] [-m memory] [-e example] [--solr-home
solr.solr.home] [--data-home solr.data.home] [--jvm-opts \"jvm-opts\"]
[--verbose]"
echo ""
echo " -f/--foreground Start Solr in foreground; default starts
Solr in the background"
echo " and sends stdout / stderr to
solr-PORT-console.log"
echo ""
+ echo " -c or --cloud No-op. Solr starts in cloud mode by default;
this flag is accepted for"
+ echo " compatibility with previous Solr scripts.
Cannot be combined with --user-managed."
+ echo ""
Review Comment:
Do we even need to mention the flag if it's noop? We could leave it an
expert stealth option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
