janhoy commented on code in PR #47:
URL: https://github.com/apache/solr-orbit/pull/47#discussion_r3330349970


##########
solrorbit/builder/downloaders/builders/source_binary_builder.py:
##########
@@ -1,3 +1,25 @@
+# SPDX-License-Identifier: Apache-2.0
+#
+# Originally developed by OpenSearch Contributors; licensed under the Apache 
License, Version 2.0.
+# License header was absent in the original source; added when adopted into 
Apache Solr Orbit.
+# Modified by Apache Solr contributors; see git log for details.

Review Comment:
   Please help decide what we should use as license header for Python files 
that did not have any header from Opensearch Benchmark project, like this. I 
suggest this one, which has the normal Apache header but this three line notice 
on top to say the file was originally authored by OSB and then modified by Solr.
   
   I felt it was overkill to add the full "The Opensearch project requires 
contributors... bla bla", and the Rally stuff. These three lines should be 
enough to let people know the origin of the file, and the git history reveals 
it all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to