renatoh commented on code in PR #4329:
URL: https://github.com/apache/solr/pull/4329#discussion_r3343912277
##########
solr/core/src/java/org/apache/solr/handler/admin/api/CreateCore.java:
##########
@@ -185,6 +185,16 @@ public static CreateCoreParams
createRequestBodyFromV1Params(SolrParams solrPara
v1ParamMap.put("collectionProperties", collectionProperties);
}
+ if (v1ParamMap.get("numShards") instanceof String numShardsStr) {
+ v1ParamMap.put("numShards", Integer.valueOf(numShardsStr));
+ }
+ if (v1ParamMap.get("loadOnStartup") instanceof String loadOnStartupStr) {
+ v1ParamMap.put("loadOnStartup", Boolean.valueOf(loadOnStartupStr));
+ }
+ if (v1ParamMap.get("newCollection") instanceof String newCollectionStr) {
+ v1ParamMap.put("newCollection", Boolean.valueOf(newCollectionStr));
+ }
+
Review Comment:
@malliaridis Your tests are passing now, but I had to do these changes,
else it blows up already on the test setup, with this exception:
` org.apache.solr.client.solrj.RemoteSolrException: Error from server at
http://127.0.0.1:53370/solr: org.apache.solr.common.SolrException: Underlying
core creation failed while creating collection: collection1
at __randomizedtesting.SeedInfo.seed([99D40937BA20F6D9]:0)
at
app//org.apache.solr.client.solrj.apache.HttpSolrClient.executeMethod(HttpSolrClient.java:685)
at
app//org.apache.solr.client.solrj.apache.HttpSolrClient.request(HttpSolrClient.java:255)
at
app//org.apache.solr.client.solrj.apache.HttpSolrClient.request(HttpSolrClient.java:234)
at
app//org.apache.solr.client.solrj.impl.LBSolrClient.doRequest(LBSolrClient.java:629)
at
app//org.apache.solr.client.solrj.impl.LBSolrClient.doRequest(LBSolrClient.java:613)
at
app//org.apache.solr.client.solrj.impl.LBSolrClient.doRequest(LBSolrClient.java:638)
at
app//org.apache.solr.client.solrj.impl.LBSolrClient.request(LBSolrClient.java:582)
at
app//org.apache.solr.client.solrj.impl.CloudSolrClient.sendRequest(CloudSolrClient.java:1596)
at
app//org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1231)
at
app//org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1153)
at
app//org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:302)
at
app//org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:348)
at
app//org.apache.solr.handler.V2ApiIntegrationTest.createCluster(V2ApiIntegrationTest.java:62)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
