dsmiley commented on code in PR #4463:
URL: https://github.com/apache/solr/pull/4463#discussion_r3345498374
##########
solr/core/src/java/org/apache/solr/handler/admin/api/OverseerOperationAPI.java:
##########
@@ -59,7 +60,7 @@ public OverseerOperationAPI(CoreAdminHandler
coreAdminHandler) {
@Command(name = OVERSEER_OP_CMD)
public void joinOverseerLeaderElection(PayloadObj<OverseerOperationPayload>
payload)
throws Exception {
- final Map<String, Object> v1Params = payload.get().toMap(new HashMap<>());
+ final Map<String, Object> v1Params = Utils.convertToMap(payload.get(), new
LinkedHashMap<>());
Review Comment:
why the change from HashMap to LinkedHashMap here?
##########
solr/core/src/java/org/apache/solr/handler/SolrConfigHandler.java:
##########
Review Comment:
The code here seems mostly populating a response. For such cases, I
question if you need to convert existing MapWriter things to SimpleOrderedMap
(e.g. by using SOM's constructor). Meaning, simply pass the MapWriter as-is.
I believe the response writers will all check the value to be of type MapWriter
and then do the right thing. I mentioned this point in Part 2 previously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
