[ 
https://issues.apache.org/jira/browse/SOLR-18281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18086650#comment-18086650
 ] 

Jan Høydahl commented on SOLR-18281:
------------------------------------

The test was indeed bad, should not have been committed in that shape. So the 
root cause was the way PackageManager prints directly to stdout, bypassing 
SolrCLI's ToolRuntime mechanism through which all output should be routed. I'll 
make the PackageToolTest pass by routing the printGreen and printRed methods 
through runtime, which both gives a better separation of concern and 
testability.

> PackageToolTest.testDeployValidationMessages reliably fails 100% of the time
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-18281
>                 URL: https://issues.apache.org/jira/browse/SOLR-18281
>             Project: Solr
>          Issue Type: Test
>            Reporter: Chris M. Hostetter
>            Assignee: Jan Høydahl
>            Priority: Major
>
> PackageToolTest.testDeployValidationMessages has a 100% jenkins failure rate 
> since it was committed a few days ago in 
> {{eaee0a20cbb7af08f86a0339654b1ce6f421dc24}} (which does not cite a jira)
> a jenkins seed picked at random reproduces reliably for me...
>  
> {noformat}
> ./gradlew test --tests PackageToolTest.testDeployValidationMessages 
> -Dtests.seed=2BE60DD7AEBCFD18 -Dtests.multiplier=3 -Dtests.locale=jgo-Latn-CM 
> -Dtests.timezone=America/Thunder_Bay -Dtests.asserts=true 
> -Dtests.file.encoding=UTF-8{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to