utsav00 opened a new pull request, #4507: URL: https://github.com/apache/solr/pull/4507
https://issues.apache.org/jira/browse/SOLR-18167 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description When upgrading from Solr 9 to 10, users who had `-Dsolr.auth.jwt.allowOutboundHttp=true` in `SOLR_OPTS` would hit a startup failure even though the old property was correctly set. The deprecated property migration was silently skipping it. # Solution `DeprecatedSystemPropertyMappings.properties` stores dot-separated keys. So the lookup never matched, and thus the migration to `solr.auth.jwt.outbound.http.enabled` was silently skipped. The fix is normalizing each system property to dot-separated before the deprecated mapping lookup. # Tests Manually verified via runDev with the option `-Dsolr.auth.jwt.allowOutboundHttp=true` and the deprecation warning appears in logs and the new property is set correctly. Example output in my run - ``` > cat solr/packaging/build/dev-slim/server/logs/solr.log | grep outbound 2026-06-07 19:16:13.886 WARN (main) [] o.a.s.c.u.EnvUtils Deprecated system property solr.auth.jwt.allowOutboundHttp has been replaced by solr.auth.jwt.outbound.http.enabled. Support for the old property will be removed in a future version of Solr. ``` # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [x] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
