epugh commented on code in PR #4510:
URL: https://github.com/apache/solr/pull/4510#discussion_r3380033070
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java:
##########
@@ -136,7 +137,22 @@ public synchronized SolrClient getHttpSolrClient(String
baseUrl) {
ensureOpen();
Objects.requireNonNull(baseUrl, "Url cannot be null!");
return httpSolrClients.computeIfAbsent(
- baseUrl, url -> newHttpSolrClientBuilder(url, httpSolrClient).build());
+ baseUrl,
+ url -> {
+ // Find an existing Cloud Client connection
+ HttpSolrClient sharedEngine = this.httpSolrClient;
Review Comment:
Maybe called it sharedClient?
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java:
##########
@@ -136,7 +137,22 @@ public synchronized SolrClient getHttpSolrClient(String
baseUrl) {
ensureOpen();
Objects.requireNonNull(baseUrl, "Url cannot be null!");
return httpSolrClients.computeIfAbsent(
- baseUrl, url -> newHttpSolrClientBuilder(url, httpSolrClient).build());
+ baseUrl,
+ url -> {
+ // Find an existing Cloud Client connection
+ HttpSolrClient sharedEngine = this.httpSolrClient;
+
+ if (sharedEngine == null && !cloudSolClients.isEmpty()) {
Review Comment:
was `cloudSolClients` spelled wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
