isaric commented on PR #4464: URL: https://github.com/apache/solr/pull/4464#issuecomment-4661016776
Rebased onto main and pushed a fixup commit (`e9572c5267c`): - `PluginInfo.writeMap`: fixed two pre-existing compile errors (`NamedList.asMap()` returns raw `Map`; parameterized `instanceof` on `Object` rejected by javac) — applied your Java-17 instanceof suggestion using raw `List list`. - `SolrConfigHandler:339, 372`: switched from `.toMap(new LinkedHashMap<>())` back to `new SimpleOrderedMap<>(...)` now that `SolrConfig` / `PluginInfo` are `MapWriter`. This preempts Part 3 removing the `toMap` default from `MapWriter`. Replied inline on the rest of the threads. Build is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
