igiguere commented on code in PR #4240:
URL: https://github.com/apache/solr/pull/4240#discussion_r3406071885
##########
solr/core/src/test/org/apache/solr/handler/admin/api/GetNodeSystemInfoTest.java:
##########
@@ -52,7 +52,23 @@ public void testGetNodeInfoHttp() throws Exception {
// Test a few values, majority of field-level validation occurs in
NodeSystemInfoProviderTest
assertEquals(0, infoRsp.responseHeader.status);
- assertEquals("std", infoRsp.mode);
- assertEquals(Version.LATEST.toString(), infoRsp.lucene.luceneSpecVersion);
+ assertEquals("std", infoRsp.nodeInfo.mode);
+ assertEquals(Version.LATEST.toString(),
infoRsp.nodeInfo.lucene.luceneSpecVersion);
+ }
+
+ @Test
+ public void testGetSpecificNodeInfo() throws Exception {
+ final var req = new SystemApi.GetSpecificNodeSystemInfo("lucene");
+
+ final var infoRsp = req.process(solrTestRule.getSolrClient(null));
+
+ // Test a few values, majority of field-level validation occurs in
NodeSystemInfoProviderTest
+ assertEquals(0, infoRsp.responseHeader.status);
+ assertNotNull(infoRsp.nodeInfo.lucene);
+ assertEquals(Version.LATEST.toString(),
infoRsp.nodeInfo.lucene.luceneSpecVersion);
+ assertNull(infoRsp.nodeInfo.jvm);
Review Comment:
Doesn't look "urgent" to me so I'll leave it as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
