adityamparikh commented on PR #150:
URL: https://github.com/apache/solr-mcp/pull/150#issuecomment-4700153884
@epugh — reopening this as the apache-side PR for the **buildSrc /
convention-plugin** take on RAT, so you can review it here. It's the
alternative to the inline `tasks.rat { }` configuration in #149.
A couple of notes for reviewing:
- It's stacked on #138 (the `buildSrc` infra), so the **Files changed** tab
includes #138's commits. The RAT-only delta is the single commit `9ec8521` —
easiest to review from the **Commits** tab.
- Kept as a **draft** because it shouldn't merge until #138 lands; the goal
right now is a review of the approach. Once #138 merges I'll rebase this down
to just the RAT commit and mark it ready.
What it does differently from #149: adds an `org.apache.solr.mcp.rat`
convention plugin alongside #138's `license-notice`, and moves the
`.gitignore`→glob translation into a pure, unit-tested `RatExcludes` helper.
That testability caught a bug in the inline version — interior-slash patterns
like `src/generated` were matched at any depth instead of being root-anchored.
`./gradlew build` passes (incl. Testcontainers integration tests) and
`./gradlew rat` is a clean audit. Happy to go whichever way you prefer — inline
(#149) or buildSrc (here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
