psalagnac commented on code in PR #4415: URL: https://github.com/apache/solr/pull/4415#discussion_r3420819225
########## changelog/unreleased/SOLR-18237-no-buffer.yml: ########## @@ -0,0 +1,7 @@ +title: Do not copy full data for UTF8 to Java string conversion for deserializing a collection state +type: fixed Review Comment: From the comments in the PR, there is a misunderstanding on the intention. The PR description indeed does not mention it, as the change log 😅 Main goal is not a performance optimization but to avoid OMM errors. I explained this in the Jira. We had many OOM repos and this trivial change had a huge for our case. I'll make this statement clearer in the changelog entry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
