dsmiley commented on code in PR #4512:
URL: https://github.com/apache/solr/pull/4512#discussion_r3421353997
##########
solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java:
##########
@@ -697,7 +698,7 @@ public void testBlockJoin() throws Exception {
final String parent_path = "/aa/bb";
try (SolrQueryRequest req =
req(
- "parent_filt", "(*:* -{!prefix f='_nest_path_' v='" + parent_path
+ "/'})",
+ "parent_filt", "({!field f='_nest_path_' v='" + parent_path +
"/'})",
Review Comment:
That change has a different underlying query & semantic effect. Formerly it
found all docs separate from that parent path, thus matched not only the root
doc but also `/aa` and `/ff` if that exists, say. You changed it to only match
documents at `/aa` exactly.
##########
solr/solr-ref-guide/modules/query-guide/pages/searching-nested-documents.adoc:
##########
Review Comment:
What I meant was that you search the whole ref guide for `_nest_path_` and
see if that specific reference is a usage example that can be simplified due to
your change. Hint: they exist. I also strongly suspect some tests are doing
this but didn't check.
In the past, we sometimes add better ways to do things but didn't do the
work of updating Solr to actually leverage what was added. As a consequence,
that wasn't helpful: people/LLMs don't know what they don't see used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
