janhoy commented on code in PR #4534:
URL: https://github.com/apache/solr/pull/4534#discussion_r3428368424
##########
solr/webapp/web/js/angular/controllers/security.js:
##########
@@ -412,6 +412,12 @@ solrAdminApp.controller('SecurityController', function
($scope, $timeout, $cooki
return false;
}
+ var username = $scope.upsertUser.username ?
$scope.upsertUser.username.trim() : "";
+ if (password === username) {
+ $scope.validationError = "Password must not be the same as the username";
+ return false;
+ }
Review Comment:
I removed the JS enforcement in UI. If the UI now received the HTTP 400
error, it triggered the generic error dialog with an empty message. But now the
security page catches the "errorDetail" from requests and displays the error in
the security page's existing error dialog, see screenshot
<img width="1069" height="636" alt="Skjermbilde 2026-06-17 kl 15 06 21"
src="https://github.com/user-attachments/assets/e093c130-8100-4a77-b84d-1104c41ffe0d";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
