janhoy commented on code in PR #4519:
URL: https://github.com/apache/solr/pull/4519#discussion_r3435523356
##########
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##########
@@ -467,10 +470,14 @@ private int handleBasicAuth(CommandLine cli) throws
Exception {
} while (password.length() == 0);
}
- boolean blockUnknown =
- Boolean.parseBoolean(
- SolrCLI.getOptionWithDeprecatedAndDefault(
- cli, "block-unknown", "blockUnknown", "true"));
+ if (username.equals(password)
+ && !EnvUtils.getPropertyAsBool(
+ Sha256AuthenticationProvider.ALLOW_USER_AS_PASSWORD_PROP,
false)) {
+ CLIO.err(
+ "Error: username and password must not be identical."
Review Comment:
This is a generic feedback of a pre-existing weakness. Could be addressed
separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
