utsav00 commented on code in PR #4535:
URL: https://github.com/apache/solr/pull/4535#discussion_r3436687675
##########
solr/solrj/src/java/org/apache/solr/common/util/EnvUtils.java:
##########
@@ -75,7 +75,9 @@ public class EnvUtils {
CUSTOM_MAPPINGS.put(key, props.getProperty(key));
}
for (String key : deprecatedProps.stringPropertyNames()) {
- DEPRECATED_MAPPINGS.put(deprecatedProps.getProperty(key), key);
+ // The lookup side (findDeprecatedMappingKey) normalises incoming
"-D" keys to
+ // dot-separated form, so normalise the old (camelCase) names here
too
+
DEPRECATED_MAPPINGS.put(camelCaseToDotSeparated(deprecatedProps.getProperty(key)),
key);
Review Comment:
Oo, I like this idea more. I was going for a redundant check that required
an extra guard -
https://github.com/apache/solr/compare/main...utsav00:solr:fix/SOLR-18167?expand=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
