dsmiley commented on code in PR #4406:
URL: https://github.com/apache/solr/pull/4406#discussion_r3444070817
##########
solr/core/src/java/org/apache/solr/search/BoolQParserPlugin.java:
##########
@@ -46,10 +48,12 @@ public Query parse() throws SyntaxError {
}
@Override
- protected BooleanQuery.Builder createBuilder() {
- BooleanQuery.Builder builder = super.createBuilder();
- builder.setMinimumNumberShouldMatch(localParams.getInt("mm", 0));
- return builder;
+ protected BooleanQuery parseImpl() throws SyntaxError {
+ BooleanQuery query = super.parseImpl();
+ SolrParams solrParams = SolrParams.wrapDefaults(localParams, params);
Review Comment:
in retrospect, I think this parser should only consult localParams. Many
internal/system query parsers only look at localParams because they don't want
possible interference of request level params for the parser used in defType
(when they are not the same usage). These internal/system query parsers are
typically not used for 'q', but of course it's allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
