[ 
https://issues.apache.org/jira/browse/SOLR-17559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18090379#comment-18090379
 ] 

David Smiley commented on SOLR-17559:
-------------------------------------

The PR here improves immutability... but the PRS aspect remains a mutable 
aspect and is IMO out of scope.  If that is to be improved, I think it'd be its 
own issue.

> DocCollection should be fully immutable.
> ----------------------------------------
>
>                 Key: SOLR-17559
>                 URL: https://issues.apache.org/jira/browse/SOLR-17559
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud, SolrJ
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>              Labels: newdev, pull-request-available
>             Fix For: 10.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> DocCollection (a collection's SolrCloud state) has a number of accessors that 
> return mutable data structures.  The worst offender is getActiveSlicesArr, 
> returning an array.  To reduce the risk of accidental changes, any state 
> exposure should be immutable.
> See this 
> [comment|https://issues.apache.org/jira/browse/SOLR-12723?focusedCommentId=17897805&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17897805]
>  for more context.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to