epugh commented on PR #4203: URL: https://github.com/apache/solr/pull/4203#issuecomment-4762602303
> Hi @epugh! Circling back to this in hopes of moving it forward. I see you replied to a bunch of my review comments, mostly affirmatively, but most of those threads are still "Unresolved" here in GH. I'm having a little trouble understanding what's still outstanding from the first PR and what you've already tackled in recent changes. > > When you get a chance could you "resolve" the things that're finished? Or alternatively, comment and remind me where we left off if you remember offhand. I went through with fresh eyes, and yeah, your comments were all very applicable! I think what we now have is much more mergable!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
