dsmiley commented on code in PR #4516:
URL: https://github.com/apache/solr/pull/4516#discussion_r3449016159
##########
solr/core/src/java/org/apache/solr/update/processor/TemplateUpdateProcessorFactory.java:
##########
@@ -79,7 +79,7 @@ protected String getMyName() {
public static Resolved getResolved(
String template, Cache<String, Resolved> cache, Pattern pattern) {
- Resolved r = cache == null ? null : cache.get(template);
+ Resolved r = cache == null ? null : cache.getIfPresent(template);
Review Comment:
yes that would definitely be better... I forgot why I didn't do that as it
crossed my mind but I think some _other_ updated files would take more changes
than I wanted to do in-scope. I'll do this at least here in a minute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
