renatoh commented on PR #4475: URL: https://github.com/apache/solr/pull/4475#issuecomment-4776902094
> I guess for both #4406 and this, we need to ask ourselves whether we want Solr's QParserPlugins to be thin wrappers around Lucene's queries and thus keep mm as integer, or if we want to add our own layers of logic on top, including handling of empty clauses. I know that our eDisMax parser takes the maximalist approach in the name of configurability. But it that the correct call for BoolQParser, or should it have been a SuperDuperBoolQParser intead? 😉 @janhoy I would argue if mm is supported, it should also handle the same expression as eDisMax, maybe a good middle ground would be to support the expressions and the -1 case, but not handle empty-clauses as eDisMax does. A query like should:title_txt_en:to, I would considered that an edge-case. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
