ercsonusharma opened a new pull request, #4546: URL: https://github.com/apache/solr/pull/4546
https://issues.apache.org/jira/browse/SOLR-18290 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Add combiner.queryDepth request parameter to the combined-query / RRF flow. It controls how many candidate documents each subquery fetches from each shard for fusion, decoupled from start + rows. Holding queryDepth constant while paging keeps the underlying candidate pool and therefore the fused ranking stable across pages. # Solution The combined-query coordinator already issues a single shard request per shard carrying every combiner.query=... key. Each shard runs all subqueries locally with the request's rows value. So per-subquery depth is governed by what the outer ResponseBuilder.shards_rows carries to createMainQuery. # Tests - Updated `DistributedCombinedQueryComponentTest#testHybridQueryWithPagination` to exercise the new param: same multi-subquery JSON request issued with and without combiner.queryDepth, asserting (a) returned doc count matches limit, (b) ordering matches RRF expectations for the configured depth. - Validation paths (combiner.queryDepth=0, combiner.queryDepth > maxQueryDepth) covered by negative-path assertions. - Existing CombinedQueryComponent and RRF tests run green. no behavior change when combiner.queryDepth is absent. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [x] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
