serhiy-bzhezytskyy commented on PR #4539:
URL: https://github.com/apache/solr/pull/4539#issuecomment-4796237760
Good call on the docker/build.gradle size, @dsmiley — I'd over-engineered it
by converting the tasks into typed task classes, which also broke at runtime
(the Copilot review caught the same script-local scoping issues, and CI hit it
on `dockerTag`).
I've reworked it to the minimal change: inject `ExecOperations` via a small
holder — the same pattern already used in `gradle/globals.gradle` — and route
the existing `exec { }` calls through it. The task definitions are otherwise
untouched. The diff is now +17/-9 instead of the previous ~380 lines.
Verified locally (Docker daemon running): `dockerBuild` builds the image and
`dockerTag` tags it successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
