dsmiley commented on code in PR #4551: URL: https://github.com/apache/solr/pull/4551#discussion_r3482398039
########## dev-tools/scripts/smokeTestRelease.py: ########## @@ -633,7 +633,7 @@ def verifyUnpacked(java, artifact, unpackPath, gitRevision, version, testArgs): # in_root_folder.remove(fileName) if isSrc: - expected_src_root_folders = ['build-tools', 'changelog', 'dev-docs', 'dev-tools', 'gradle', 'solr'] Review Comment: I think that's an obsolete concern, and we should remove this check altogether. Perhaps long ago the source release was built manually and had risk of including temp/junk but the process today is from what's _committed_ to source control (*not* the working tree). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
