markrmiller opened a new pull request, #4615:
URL: https://github.com/apache/solr/pull/4615
## Summary
This ports the useful part of apache/solr#4431 into this fork's current
HTTP/2-only shard handler path.
- run distributed-search shard request setup on per-task virtual threads
- keep the existing `LBHttp2SolrClient.asyncReq(...)` callback completion
path
- track cancellation per submitted shard instead of by `ShardRequest`
- close the shard setup executor before the load balancer
- add a regression covering same-`ShardRequest` multi-shard cancellation,
setup failure, and late callbacks after `cancelAll()`
## Why
The upstream PR targets `LBAsyncSolrClient.requestAsync(...)` and older
handler structure. This fork already removed those paths and uses
`LBHttp2SolrClient.asyncReq(...)`, so this is a fork-native conceptual port
rather than a raw cherry-pick.
## Validation
- `git diff --check`
- `JAVA_HOME=/usr/lib/jvm/java-25-openjdk-amd64 ./gradlew
:solr:core:compileJava :solr:core:compileTestJava`
- `JAVA_HOME=/usr/lib/jvm/java-25-openjdk-amd64 ./gradlew :solr:core:test
--tests "org.apache.solr.handler.component.TestHttpShardHandlerFactory"`
- XML: `tests="23" skipped="0" failures="0" errors="0"`
- `JAVA_HOME=/usr/lib/jvm/java-25-openjdk-amd64 ./gradlew :solr:core:test
--tests "org.apache.solr.core.TestShardHandlerFactory"`
- XML: `tests="1" skipped="0" failures="0" errors="0"`
- `JAVA_HOME=/usr/lib/jvm/java-25-openjdk-amd64 ./gradlew :solr:core:test
--tests "org.apache.solr.handler.component.ShardsWhitelistTest"`
- XML: `tests="1" skipped="0" failures="0" errors="0"`
- `JAVA_HOME=/usr/lib/jvm/java-25-openjdk-amd64 ./gradlew :solr:core:test
--tests
"org.apache.solr.handler.component.DistributedQueryComponentOptimizationTest"`
- XML: `tests="8" skipped="2" failures="0" errors="0"`
- `grep -R "ParallelHttpShardHandler" -n solr/core/src solr/solrj/src`
produced no matches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
