abumarjikar opened a new pull request, #4627: URL: https://github.com/apache/solr/pull/4627
https://issues.apache.org/jira/browse/SOLR-18160 # Description Deprecate the legacy `ADDROLE` and `REMOVEROLE` Overseer Collection API operations. Users should transition to managing node roles at startup via the `-Dsolr.node.roles` parameter. # Solution * Added deprecation logging messages using `DeprecationLog.log` in `OverseerRoleCmd.java` for both `ADDROLE` and `REMOVEROLE` operations, alerting users that they will be removed in Solr 11. * Added `@Deprecated(since = "10.1")` annotations and updated JavaDoc documentation for `addRole` and `removeRole` helper methods within `CollectionAdminRequest.java`. * Marked `ADDROLE` and `REMOVEROLE` enum entries with `@Deprecated(since = "10.1")` in `CollectionAction` inside `CollectionParams.java`. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [ ] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
