potiuk commented on PR #4522: URL: https://github.com/apache/solr/pull/4522#issuecomment-4934441550
Thanks @dsmiley — this is exactly the review the draft needed. Going through your points: - **"So much to read / repetitive"** — fair, and the most important note here. The §9/§11a/§13/§14 sections re-state framing that §2/§3/§8 already establish. We'll do a consolidation pass to cut the repetition down — a threat model nobody reads because it's too long isn't doing its job. - **Disposition names (§13)** — you're free to name them however you like. They're not an industry term; they come from the threat-model-producer rubric we drafted against, not an external standard. Rename to whatever reads best for Solr. - **SolrJ** — agreed, the client library is a different trust surface; we'll pull it out of the main scope (either a clearly-separate section or explicitly out-of-model for this pass). - **Config role** — good call; we'll broaden it to *all* configuration (config/configSet manipulation), and note there's deliberately no separate role from admin. - **"build"** — agreed, we'll strike it. The model governs the standard binary Solr; the `non-default-build` phrasing muddies that. - **Lucene as a dependency** — agreed, nothing special about Lucene; we'll reframe as "any dependency, case-by-case: is there something reasonable Solr should do about it." I'll push a commit with these (the trim + the four wording/scope fixes) so you and @anshumg are reviewing the tightened version — or if you'd rather fold them in as you merge, say so and I'll leave it to you. Either way none of this blocks: merging is the ratification and the model becomes yours to refine in place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
