[
https://issues.apache.org/jira/browse/SOLR-17968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18095300#comment-18095300
]
ASF subversion and git services commented on SOLR-17968:
--------------------------------------------------------
Commit 712c94a47ba1ac4c15dc890566fb5ddac437b97d in solr's branch
refs/heads/main from Serhiy Bzhezytskyy
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=712c94a47ba ]
SOLR-17968: narrow CoreContainer.getDefaultHttpSolrClient() to HttpSolrClient
Return the base HttpSolrClient type instead of the concrete
HttpJettySolrClient, so
consumers don't couple to the Jetty implementation. Modules generally don't
care.
Widened 4 internal callers to the base type (ColStatus, IterativeMergeStrategy,
SolrConfigHandler.PerReplicaCallable) or the base API (PackageAPI now uses
processWithBaseUrl). Five callers keep a cast to HttpJettySolrClient because
they
genuinely use Jetty-only API: Builder.withHttpClient (shares Jetty transport
internals),
getHttpClient() for raw proxying, and the async requestWithBaseUrl(baseUrl, fn)
overload.
Pure compile-time change; runtime behavior is unchanged. Experimental; for
discussion
on whether to keep here or split out.
> Add HttpSolrClient as base class
> --------------------------------
>
> Key: SOLR-17968
> URL: https://issues.apache.org/jira/browse/SOLR-17968
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Affects Versions: 10.0
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Labels: pull-request-available
> Fix For: 10.1
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Add HttpSolrClient base class with {{{}getBaseURL(){}}}. HttpSolrClientBase
> (base of Jetty & JDK clients) shall implement it.
> The "old" HttpSolrClient (the implementation using Apache HttpClient) is
> temporarily in the test framework on death row.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
