bartoszfidrysiak commented on PR #4621: URL: https://github.com/apache/solr/pull/4621#issuecomment-4952553840
@dsmiley Could you clarify what you mean by "after the `LazyStringValue` is moved"? Currently, the class is defined in the same package as `CollapsingQParserPlugin` (the only caller), which allows it to be package-scoped. I see two options: - Make it a private static inner class of `CollapsingQParserPlugin` - Move it to a different package (if so, which one? Any suggestion?) I'd like to confirm the intended approach before making the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
