serhiy-bzhezytskyy opened a new pull request, #4638:
URL: https://github.com/apache/solr/pull/4638
On a connection failure, `ConcurrentUpdateBaseSolrClient`'s runner passed
the raw exception to the error handler with no indication of which server it
was talking to — the original SOLR-7177 complaint. The synchronous clients
already wrap connection failures with the URL (`HttpJdkSolrClient`,
`HttpSolrClient`); this brings the async path in line.
The runner now wraps a non-Solr exception in a `SolrServerException`
carrying the base URL. A `RemoteSolrException` already carries its URL, so it
passes through unchanged.
While verifying this I traced the SolrCloud distribution path
(`SolrCmdDistributor.checkRetry` via
`ErrorReportingConcurrentUpdateSolrClient`) and it turned out to matter for
retries, not just logging. `checkRetry` inspects the exception like this:
```java
if (err.e instanceof SolrServerException) {
if (isRetriableException(((SolrServerException) err.e).getRootCause()))
return true; // unwraps
} else {
if (isRetriableException(err.e)) return true; // top-level type only
}
```
On the Jetty path a connection failure arrives as a raw
`ExecutionException`, which hits the `else` branch and isn't recognized as
retriable — so a transient failure to a replica isn't retried. Wrapping it as a
`SolrServerException` puts it in the shape `checkRetry` unwraps via
`getRootCause()`, so a socket-rooted cause (e.g. `ConnectException`) is now
correctly seen as retriable. This never stops a previously-retried case from
retrying; it starts retrying the socket-rooted ones the async path was
dropping. That overlaps with SOLR-9355.
Tests added in `ConcurrentUpdateSolrClientTestBase` (both transports): the
reported error identifies the target server, and it's a `SolrServerException`
preserving the original cause so `checkRetry` can unwrap it.
@markrmiller — you had reservations on this ticket back in 2015 (the client
knows its own URL). The retry-path finding above is the part I'd flag: the
async CUSC path wasn't producing the `SolrServerException` shape `checkRetry`
was built to unwrap. Happy to adjust the approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
