epugh commented on code in PR #4629:
URL: https://github.com/apache/solr/pull/4629#discussion_r3586942147
##########
solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java:
##########
@@ -241,7 +241,7 @@ private void logWelcomeBanner(Properties props) {
"Solr typically starts with \"-XX:+CrashOnOutOfMemoryError\"
that will crash on any OutOfMemoryError exception. "
+ "Unable to get the specific file due to an exception."
+ "The cause of the OOME will be logged in a crash file in
the logs directory: %s",
- System.getProperty("solr.logs.dir"));
+ EnvUtils.getProperty("solr.logs.dir"));
Review Comment:
bit nervous on this, but dug in more and looks okay.
##########
solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java:
##########
@@ -241,7 +241,7 @@ private void logWelcomeBanner(Properties props) {
"Solr typically starts with \"-XX:+CrashOnOutOfMemoryError\"
that will crash on any OutOfMemoryError exception. "
+ "Unable to get the specific file due to an exception."
+ "The cause of the OOME will be logged in a crash file in
the logs directory: %s",
- System.getProperty("solr.logs.dir"));
+ EnvUtils.getProperty("solr.logs.dir"));
Review Comment:
bit nervous on this, but dug in more and looks okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
