dsmiley commented on code in PR #4639:
URL: https://github.com/apache/solr/pull/4639#discussion_r3587504656
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##########
@@ -144,8 +144,10 @@ protected HttpJdkSolrClient(String serverBaseUrl,
HttpJdkSolrClient.Builder buil
protected CompletableFuture<HttpResponse<InputStream>>
requestInputStreamAsync(
String baseUrl, final SolrRequest<?> solrRequest, String collection) {
try {
- HttpRequest httpRequest = prepareRequest(baseUrl, solrRequest,
collection).reqb.build();
- return httpClient.sendAsync(httpRequest,
HttpResponse.BodyHandlers.ofInputStream());
+ PreparedRequest pReq = prepareRequest(baseUrl, solrRequest, collection);
Review Comment:
nit: I favored how it was before with building the HttpRequest in this line
instead of PreparedRequest and building in the next line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
