dsmiley commented on code in PR #4646:
URL: https://github.com/apache/solr/pull/4646#discussion_r3612203751
##########
changelog/unreleased/SOLR-18310-otel-jdk-sender.yml:
##########
@@ -0,0 +1,9 @@
+title: >
+ Removed OkHttp, gRPC, and Netty jars from the opentelemetry module. The
OTLP/http protocol still
+ works but no longer uses additional dependencies.
+type: dependency_update
Review Comment:
Not a typical dependency_update usage (isn't an upgrade) but why not use it
here.
CC @janhoy
##########
solr/core/src/java/org/apache/solr/metrics/otel/MetricExporterFactory.java:
##########
@@ -25,7 +25,7 @@ public interface MetricExporterFactory {
Boolean.parseBoolean(EnvUtils.getProperty("solr.metrics.otlpExporterEnabled",
"false"));
public static final String OTLP_EXPORTER_PROTOCOL =
- EnvUtils.getProperty("solr.metrics.otlpExporterProtocol", "grpc");
+ EnvUtils.getProperty("solr.metrics.otlpExporterProtocol", "http");
Review Comment:
OTLP http/protobuf is widely supported OOTB on recipients AFAICT. I suspect
users won't notice this change, but it's not something to withhold from a
changelog.
I do expect a there would be a performance difference, albeit not much for a
reasonably performant http stack (I think JDK HttpClient is such).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
