malliaridis opened a new pull request, #4650:
URL: https://github.com/apache/solr/pull/4650

   See discussion 
https://lists.apache.org/thread/onc0zyyp8tjoj3fdg3bmpnh9cqsgjhy6
   
   # Description
   
   We have noticed slow build times and problems related to the Admin UI module 
that requires developers to disable the module entirely, which led to other 
dependency resolution issues.
   
   This PR attempts to separate the module from the rest of the project by 
making it an independent sub-project.
   
   # Solution
   
   The approach that was picked is a completely independent gradle project. 
Some important changes:
   
   - Dependency resolution for the UI module is happening separately from the 
rest of the project, so dependencies are not aligned
   - Many build configurations that apply to most `solr` modules are removed, 
allowing the UI module to use simpler builds
   - The exclusion of many plugins and configurations means there are no 
default checks included
   - [TODO further changes]
   
   We should evaluate before merging which of the configurations or routines we 
want to keep and apply to this module as well.
   
   The module is no longer included as a configuration or task dependency as 
implemented before. Instead, the webapp now has to fetch the UI artifacts from 
[TODO].
   
   # Tests
   
   Please describe the tests you've developed or run to confirm this patch 
implements the feature or solves the problem.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [ ] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended, not available for 
branches on forks living under an organisation)
   - [ ] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   - [ ] I have added a [changelog 
entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my 
change
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to