epugh commented on code in PR #4653:
URL: https://github.com/apache/solr/pull/4653#discussion_r3638152885


##########
solr/benchmark/src/java/org/apache/solr/bench/search/RequestWriters.java:
##########
@@ -60,7 +60,7 @@ public class RequestWriters {
   @State(Scope.Benchmark)
   public static class BenchState {
 
-    @Param({"xml", "binary"})
+    @Param({"xml", "javabin"})

Review Comment:
   Bug fix here?   Nice to see the benchmarks get used and therefore finding 
oversights like this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to