jaykay12 commented on code in PR #4663:
URL: https://github.com/apache/solr/pull/4663#discussion_r3651183920
##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -220,23 +250,6 @@ private static Tool newTool(String toolType, ToolRuntime
runtime) throws Excepti
throw new IllegalArgumentException(toolType + " is not a valid command!");
}
- /**
- * Returns the value of the option with the given name, or the value of the
deprecated option. If
- * both values are null, then it returns the default value.
- *
- * <p>If this method is marked as unused by your IDE, it means we have no
deprecated CLI options
- * currently, congratulations! This method is preserved for the next time we
need to deprecate a
- * CLI option.
- */
- public static String getOptionWithDeprecatedAndDefault(
- CommandLine cli, Option opt, Option deprecated, String def) {
- String val = cli.getOptionValue(opt);
- if (val == null) {
- val = cli.getOptionValue(deprecated);
- }
- return val == null ? def : val;
- }
-
Review Comment:
Unused method. thus removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
