epugh opened a new pull request, #4672:
URL: https://github.com/apache/solr/pull/4672

   ## Summary
   - `bin/solr create` previously uploaded configsets by opening a direct 
ZooKeeper connection (`ZkConfigSetService`) and reading `/configs/<name>` 
directly to check for an existing configset. It now does both via the 
Configsets V2 API (`ConfigsetsApi.ListConfigSet` / 
`ConfigsetsApi.UploadConfigSet`), zipping the local configset directory for 
upload.
   - `createCollection`/`createCore` now just take a `SolrClient` rather than 
requiring a `CloudSolrClient` built from a ZooKeeper connection string. The 
only remaining ZK-specific step is resolving *a* live node's URL when the user 
only supplies `--zk-host` (no `--solr-url`) — done once via 
`CLIUtils.normalizeSolrUrl`.
   
   ## Test plan
   - [x] `CreateToolTest` passes, including a new 
`testCreateCollectionUploadsNewConfigSet` test that exercises the fresh-upload 
path (not just the reuse-existing-configset path the original test covered)
   - [x] `./gradlew :solr:core:spotlessJavaCheck` clean
   - [x] `./gradlew :solr:core:compileJava :solr:core:compileTestJava` clean
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to