dsmiley opened a new pull request, #4675: URL: https://github.com/apache/solr/pull/4675
There are foot-guns in creating Executors. This PR adds checks in ExecutorUtil designed to catch them. Read the javadocs I'm adding there. Additionally, one `ExecutorUtil.newMDCAwareCachedThreadPool` method is misleading as-named since it creates a pool consistent with a fixed pool -- min & max size equal and a real/sized queue (not SynchronousQueue). Yes `allowCoreThreadTimeOut` is set but IMO that doesn't change the fundamental characterization of the pool. This even confused Claude Opus, as I worked on something and it called factory this method and then later realized it's name mislead it, as it should have chosen another one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
