serhiy-bzhezytskyy commented on PR #60: URL: https://github.com/apache/solr-orbit/pull/60#issuecomment-5093779738
Filed the auto-resolve follow-up as #61 so it isn't lost. One thing worth flagging that came out of writing it up: the stored test run doesn't currently record *where* the workload came from. `TestRun.as_dict()` persists the workload name, `workload-params` and `workload-revision`, and `from_dict()` restores those three — but nothing says whether the run used the default repository, another repository, or a local path. So auto-resolving would need that field persisted first, plus a fallback for test-run files written before the change (there's precedent for that grace period in `metrics.py`). The issue spells that out, along with the two decisions that seem worth settling before any code: whether the field is optional-with-fallback indefinitely or on a deprecation clock, and whether it's worth coordinating with OpenSearch Benchmark, since `aggregator.py` there is the same file apart from the import. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
