epugh commented on code in PR #4657:
URL: https://github.com/apache/solr/pull/4657#discussion_r3669638952
##########
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##########
@@ -367,65 +352,48 @@ private void distribute(FileInfo info) {
} catch (Exception e) {
throw new SolrException(SERVER_ERROR, "Unable to create an entry in ZK",
e);
}
- tmpFiles.put(info.path, info);
List<String> nodes =
FileStoreUtils.fetchAndShuffleRemoteLiveNodes(coreContainer);
int i = 0;
int FETCHFROM_SRC = 50;
String myNodeName = coreContainer.getZkController().getNodeName();
- String getFrom = "";
- try {
Review Comment:
@psalagnac can you eyeball one more cahnge? So I looked at what copilot
said, and then I eneded up removing the entire outer `try` loop, and then the:
```
coreContainer
.getUpdateShardHandler()
.getUpdateExecutor()
.submit(
```
because at this point, there isn't anything left. Does this all make
sense? I'm always nervous around threds ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
