janhoy commented on PR #1151: URL: https://github.com/apache/solr/pull/1151#issuecomment-5141738466
Good feedback. * Perhaps `DEBUG` level is sufficient here. But I thought it is not uncommon to put an entire solr node in DEBUG mode for some extended time during any debugging, and that would then lead to potential unintended leaks to logs. So having to enable TRACE on the targeted classes (if documented) is safer * Could be that there should be some system-wide utility except for log4j config to control or unify disclosure of index content outside of a search. Perhaps a dedicated INFOSTREAM like log that gives insight into the ingest pipeline? But that's out of scope for this JIRA Next action on this could be A) Abandon, no need leave as is B) Use DEBUG level, document it, ship it. Simplest thing without new architectural constructs. C) Introduce mechanism X cross the board I agree that fixing this in the simplest way now gives no guarantee that a developer adds new error logging that leaks data tomorrow. But that is kind of hard to guard against even if there exists some common class or utility, if it is not used. Kind of like our allowLists... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
