epugh commented on code in PR #4689:
URL: https://github.com/apache/solr/pull/4689#discussion_r3692831099
##########
solr/core/src/test/org/apache/solr/cloud/api/collections/ShardSplitTest.java:
##########
@@ -1269,8 +1271,8 @@ protected void splitShard(
if (splitKey != null) {
params.set("split.key", splitKey);
}
- QueryRequest request = new QueryRequest(params);
- request.setPath("/admin/collections");
+ var request =
Review Comment:
Normally when I see a GSR I think "We should be using one of our strongly
typed OpenAPI classes" ;-). But in this case, I think it's better ;-).
##########
solr/core/src/test/org/apache/solr/search/TestSmileRequest.java:
##########
@@ -74,10 +74,6 @@ public void assertJQ(SolrClient client, SolrParams args,
String... tests)
throws Exception {
QueryRequest query = new QueryRequest(args);
query.setResponseParser(new SmileResponseParser());
- String path = args.get("qt");
Review Comment:
Love seeing another `qt` bite the dust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
